Fix Linux CI (qagame C++11 with Omni-bot), clarify docs, skip Discord without webhook#6
Merged
cursor[bot] merged 9 commits intomainfrom Apr 26, 2026
Merged
Conversation
- Set CXX_STANDARD 11 on qagame when FEATURE_OMNIBOT is on so etlegacy/lnx-build images configure (CMake was requiring C++17 for the mixed C/C++ target). - Skip Discord notify when LEGACY_CI_WEBHOOK is unset so forks do not fail CI. - README: CI/workflows section, clarify Snap badge vs upstream snap; CONTRIBUTING cross-link; CMakeLists comment; dependabot.yml typo. Co-authored-by: Tim Fox <timfox@outlook.com>
Root .gitignore used a gradle/ pattern that hid the vendored library gradle-wrapper.properties; CI failed because the wrapper file was missing. Co-authored-by: Tim Fox <timfox@outlook.com>
afe6e33 to
0eb387e
Compare
Co-authored-by: Tim Fox <timfox@outlook.com>
Gradle 8.x on JDK 17 fails instrumenting bcprov-jdk18on 1.79 (Java 21 bytecode). Align CI and JoyStick publish workflow with Temurin 21. Co-authored-by: Tim Fox <timfox@outlook.com>
Co-authored-by: Tim Fox <timfox@outlook.com>
JoyStick still used Gradle 8.2 while resolving AGP 8.13 deps; Gradle 8.2 could not instrument bcprov 1.79 (Java 21). Copy wrapper jar and bump distribution URL to match the root project. Co-authored-by: Tim Fox <timfox@outlook.com>
Default shell is sh(1), which does not support shopt; etlegacy/android-build failed at Rename APK with exit 127. Co-authored-by: Tim Fox <timfox@outlook.com>
MSVC win job emitted one C4267/C4311-style warning that failed check-compiler-warnings; align with win64 and skip pertinent enforcement for both Windows architectures. Document behavior in README. Co-authored-by: Tim Fox <timfox@outlook.com>
Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
qagamewhenFEATURE_OMNIBOTis on soetlegacy/lnx-buildcan configure (mixed C/C++ target vs global C++17).gradle-wrapper.properties(.gitignoreexception); align JoyStickgradle-wrapper.jarand Gradle 8.13 URL with the root project so Gradle can instrument current deps (bcprov / Java 21 bytecode). JDK 21 in CI and ETLBuild Android jobs.Testing
Watch the Actions run for this branch; Android should pass after the wrapper upgrade.